Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitizing comments JSON #30356

Merged

Conversation

victoralfaro-dotcms
Copy link
Contributor

Before parsing JSON we need to sanitize JSON returned by Github API.

@victoralfaro-dotcms victoralfaro-dotcms marked this pull request as ready for review October 15, 2024 23:05
@victoralfaro-dotcms victoralfaro-dotcms requested a review from a team as a code owner October 15, 2024 23:05
Copy link
Contributor

@wezell wezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better

@wezell wezell added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@victoralfaro-dotcms victoralfaro-dotcms added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 167058a Oct 16, 2024
18 of 19 checks passed
@victoralfaro-dotcms victoralfaro-dotcms deleted the sanitizing-comments-json-before-processing branch October 16, 2024 20:09
spbolton pushed a commit that referenced this pull request Nov 11, 2024
Before parsing JSON we need to sanitize JSON returned by Github API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants